Skip to content

HADOOP-16453. Update how exceptions are handled in NetUtils.java#1231

Closed
leosunli wants to merge 1 commit intoapache:trunkfrom
leosunli:trace_log
Closed

HADOOP-16453. Update how exceptions are handled in NetUtils.java#1231
leosunli wants to merge 1 commit intoapache:trunkfrom
leosunli:trace_log

Conversation

@leosunli
Copy link
Contributor

@leosunli leosunli commented Aug 6, 2019

Signed-off-by: sunlisheng sunlisheng@xiaomi.com

Update how exceptions are handled in NetUtils.java
ee40d94 
Signed-off-by: sunlisheng <sunlisheng@xiaomi.com>
@hadoop-yetus
Copy link

hadoop-yetus commented Aug 8, 2019

🎊 +1 overall

Vote Subsystem Runtime Comment
0 reexec 41 Docker mode activated.
_ Prechecks _
+1 dupname 0 No case conflicting files found.
+1 @author 0 The patch does not contain any @author tags.
+1 test4tests 0 The patch appears to include 2 new or modified test files.
_ trunk Compile Tests _
+1 mvninstall 1079 trunk passed
+1 compile 1044 trunk passed
+1 checkstyle 41 trunk passed
+1 mvnsite 70 trunk passed
+1 shadedclient 725 branch has no errors when building and testing our client artifacts.
+1 javadoc 55 trunk passed
0 spotbugs 112 Used deprecated FindBugs config; considering switching to SpotBugs.
+1 findbugs 111 trunk passed
_ Patch Compile Tests _
+1 mvninstall 47 the patch passed
+1 compile 1030 the patch passed
+1 javac 1030 the patch passed
+1 checkstyle 38 the patch passed
+1 mvnsite 66 the patch passed
+1 whitespace 0 The patch has no whitespace issues.
+1 shadedclient 629 patch has no errors when building and testing our client artifacts.
+1 javadoc 54 the patch passed
+1 findbugs 122 the patch passed
_ Other Tests _
+1 unit 542 hadoop-common in the patch passed.
+1 asflicense 44 The patch does not generate ASF License warnings.
5803
Subsystem Report/Notes
Docker Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/hadoop-multibranch/job/PR-1231/1/artifact/out/Dockerfile
GITHUB PR #1231
Optional Tests dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient findbugs checkstyle
uname Linux cf745b741009 4.4.0-138-generic #164-Ubuntu SMP Tue Oct 2 17:16:02 UTC 2018 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality personality/hadoop.sh
git revision trunk / 3cc0ace
Default Java 1.8.0_222
Test Results https://builds.apache.org/job/hadoop-multibranch/job/PR-1231/1/testReport/
Max. process+thread count 1449 (vs. ulimit of 5500)
modules C: hadoop-common-project/hadoop-common U: hadoop-common-project/hadoop-common
Console output https://builds.apache.org/job/hadoop-multibranch/job/PR-1231/1/console
versions git=2.7.4 maven=3.3.9 findbugs=3.1.0-RC1
Powered by Apache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

@jojochuang jojochuang mentioned this pull request Aug 8, 2019
Closed
@hadoop-yetus
Copy link

hadoop-yetus commented Aug 8, 2019

🎊 +1 overall

Vote Subsystem Runtime Comment
0 reexec 84 Docker mode activated.
_ Prechecks _
+1 dupname 0 No case conflicting files found.
+1 @author 0 The patch does not contain any @author tags.
+1 test4tests 0 The patch appears to include 2 new or modified test files.
_ trunk Compile Tests _
+1 mvninstall 1224 trunk passed
+1 compile 1182 trunk passed
+1 checkstyle 53 trunk passed
+1 mvnsite 87 trunk passed
+1 shadedclient 897 branch has no errors when building and testing our client artifacts.
+1 javadoc 62 trunk passed
0 spotbugs 135 Used deprecated FindBugs config; considering switching to SpotBugs.
+1 findbugs 133 trunk passed
_ Patch Compile Tests _
+1 mvninstall 55 the patch passed
+1 compile 1040 the patch passed
+1 javac 1040 the patch passed
+1 checkstyle 48 the patch passed
+1 mvnsite 85 the patch passed
+1 whitespace 0 The patch has no whitespace issues.
+1 shadedclient 744 patch has no errors when building and testing our client artifacts.
+1 javadoc 67 the patch passed
+1 findbugs 132 the patch passed
_ Other Tests _
+1 unit 621 hadoop-common in the patch passed.
+1 asflicense 46 The patch does not generate ASF License warnings.
6617
Subsystem Report/Notes
Docker Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/hadoop-multibranch/job/PR-1231/2/artifact/out/Dockerfile
GITHUB PR #1231
Optional Tests dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient findbugs checkstyle
uname Linux 0765c18eb250 4.15.0-54-generic #58-Ubuntu SMP Mon Jun 24 10:55:24 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality personality/hadoop.sh
git revision trunk / 00b5a27
Default Java 1.8.0_222
Test Results https://builds.apache.org/job/hadoop-multibranch/job/PR-1231/2/testReport/
Max. process+thread count 1377 (vs. ulimit of 5500)
modules C: hadoop-common-project/hadoop-common U: hadoop-common-project/hadoop-common
Console output https://builds.apache.org/job/hadoop-multibranch/job/PR-1231/2/console
versions git=2.7.4 maven=3.3.9 findbugs=3.1.0-RC1
Powered by Apache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

@hadoop-yetus
Copy link

hadoop-yetus commented Aug 16, 2019

💔 -1 overall

Vote Subsystem Runtime Comment
0 reexec 0 Docker mode activated.
-1 patch 10 #1231 does not apply to trunk. Rebase required? Wrong Branch? See https://wiki.apache.org/hadoop/HowToContribute for help.
Subsystem Report/Notes
GITHUB PR #1231
Console output https://builds.apache.org/job/hadoop-multibranch/job/PR-1231/3/console
versions git=2.17.1
Powered by Apache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

@hadoop-yetus
Copy link

hadoop-yetus commented Aug 20, 2019

💔 -1 overall

Vote Subsystem Runtime Comment
0 reexec 0 Docker mode activated.
-1 patch 13 #1231 does not apply to trunk. Rebase required? Wrong Branch? See https://wiki.apache.org/hadoop/HowToContribute for help.
Subsystem Report/Notes
GITHUB PR #1231
Console output https://builds.apache.org/job/hadoop-multibranch/job/PR-1231/4/console
versions git=2.7.4
Powered by Apache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

steveloughran
steveloughran reviewed Aug 21, 2019
View reviewed changes
hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/net/TestNetUtils.java
assertInException(wrapped, "Host Details ");
assertRemoteDetailsIncluded(wrapped);
IOException wrapped = verifyExceptionClass(e, TestIOException.class);
assertEquals(null, wrapped.getMessage());
Copy link
Contributor

@steveloughran steveloughran Aug 21, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

assertNull, with error text please

@hadoop-yetus
Copy link

hadoop-yetus commented Sep 3, 2019

💔 -1 overall

Vote Subsystem Runtime Comment
0 reexec 0 Docker mode activated.
-1 patch 10 #1231 does not apply to trunk. Rebase required? Wrong Branch? See https://wiki.apache.org/hadoop/HowToContribute for help.
Subsystem Report/Notes
GITHUB PR #1231
Console output https://builds.apache.org/job/hadoop-multibranch/job/PR-1231/7/console
versions git=2.17.1
Powered by Apache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

@apache apache deleted a comment from hadoop-yetus Sep 3, 2019
@apache apache deleted a comment from hadoop-yetus Sep 3, 2019
@steveloughran
Copy link
Contributor

steveloughran commented Sep 3, 2019

this is in; closing

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@steveloughran steveloughran steveloughran left review comments

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@leosunli @hadoop-yetus @steveloughran